[SOLVED] Extension Review Process, Released

tgraupmann · December 17, 2017, 7:17pm

(edit) Posted above.

Yes the code is readable. I used the Atom editor and everything is formatted nice.

With the exception of the ChromaSDK which I minified and inlined at the top of viewer.js.

razerofficial/HTML5ChromaSDK/blob/master/ChromaSDKImpl.js

// JavaScript source code

function ChromaSDK() {
    var uri = undefined;
    var timerId = undefined;
    var initialized = false;
}

ChromaSDK.prototype = {
	uri: undefined,
    onTimer: function () {
      var refThis = chromaSDK; // used on interval so this is out of scope
      if (refThis.uri == undefined) {
        return;
      }

      if (!refThis.initialized) {
        return;
      }

This file has been truncated. show original

Oopps. I did include JQuery and JSZip from the viewer.html. And I could have inlined the JSZip library.

        <script src="https://extension-files.twitch.tv/helper/v1/twitch-ext.min.js"></script>
        <script src="js/jquery.min.js"></script>
        <script src="js/jszip.min.js"></script>
        <script src="js/common.js"></script>
        <script src="js/viewer.js"></script>

Thanks for that. Okay I’ve inlined the JavaScript minified for JQuery and JSZiip libraries into the viewer.js.